[git commit] ftpd: fix a case when with -w unknown commands are ignored with no error code

Denys Vlasenko vda.linux at googlemail.com
Thu Jun 4 17:03:20 UTC 2009


commit: http://git.busybox.net/busybox/commit/?id=8507e1f10927bc6498cf38eb8324a53bde8e0a61
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master


Signed-off-by: Stefan Seyfried <seife at suse.de>
Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 networking/ftpd.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/networking/ftpd.c b/networking/ftpd.c
index 2ec67df..090ed54 100644
--- a/networking/ftpd.c
+++ b/networking/ftpd.c
@@ -1320,6 +1320,8 @@ int ftpd_main(int argc UNUSED_PARAM, char **argv)
 				handle_appe();
 			else if (cmdval == const_STOU) /* "store unique" */
 				handle_stou();
+			else
+				goto bad_cmd;
 		}
 #endif
 #if 0
@@ -1340,6 +1342,9 @@ int ftpd_main(int argc UNUSED_PARAM, char **argv)
 			 * (doesn't necessarily mean "we must support them")
 			 * foo 1.2.3: XXXX - comment
 			 */
+#if ENABLE_FEATURE_FTP_WRITE
+ bad_cmd:
+#endif
 			cmdio_write_raw(STR(FTP_BADCMD)" Unknown command\r\n");
 		}
 	}
-- 
1.6.0.6


More information about the busybox-cvs mailing list