[git commit] fix mount test false positive

Denys Vlasenko vda.linux at googlemail.com
Sat Jul 18 15:22:03 UTC 2009


commit: http://git.busybox.net/busybox/commit/?id=c1fc3d3000f27f3c266ba606a186b9b1da0b0c2c
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master


Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 testsuite/mount.tests |   12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/testsuite/mount.tests b/testsuite/mount.tests
index c8381a0..f4a2cc2 100755
--- a/testsuite/mount.tests
+++ b/testsuite/mount.tests
@@ -9,11 +9,13 @@ test "`id -u`" = 0 || {
 	exit 0
 }
 
+testdir=$PWD/testdir
+
 dd if=/dev/zero of=mount.image1m count=1 bs=1M 2>/dev/null || { echo "dd error"; exit 1; }
 mkfs.minix -v mount.image1m >/dev/null 2>&1 || { echo "mkfs.minix error"; exit 1; }
-testdir=$PWD/testdir
-mkdir $testdir 2>/dev/null
-umount -d $testdir 2>/dev/null
+modprobe minix 2>/dev/null
+mkdir "$testdir" 2>/dev/null
+umount -d "$testdir" 2>/dev/null
 
 # testing "test name" "command" "expected result" "file input" "stdin"
 #   file input will be file called "input"
@@ -27,8 +29,8 @@ testing "mount -o remount,mand" \
 	"1\n""1\n" \
 	"" ""
 
-umount -d $testdir
-rmdir $testdir
+umount -d "$testdir"
+rmdir "$testdir"
 rm mount.image1m
 
 exit $FAILCOUNT
-- 
1.6.3.3


More information about the busybox-cvs mailing list