[git commit] another small lineedit fix

Denys Vlasenko vda.linux at googlemail.com
Thu Jul 16 12:33:16 UTC 2009


commit: http://git.busybox.net/busybox/commit/?id=9531f7dad708b9130142aaaac6ed095f23ed3c35
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master


Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 libbb/lineedit.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/libbb/lineedit.c b/libbb/lineedit.c
index a3d9395..9a773b4 100644
--- a/libbb/lineedit.c
+++ b/libbb/lineedit.c
@@ -429,7 +429,9 @@ static void input_delete(int save)
 #endif
 
 	memmove(command_ps + j, command_ps + j + 1,
-			(command_len - j + 1) * sizeof(command_ps[0]));
+			/* (command_len + 1 [because of NUL]) - (j + 1)
+			 * simplified into (command_len - j) */
+			(command_len - j) * sizeof(command_ps[0]));
 	command_len--;
 	input_end();                    /* rewrite new line */
 	cmdedit_set_out_char(' ');      /* erase char */
-- 
1.6.3.3


More information about the busybox-cvs mailing list