[git commit master] ash: trivial optimization -6 bytes

Denys Vlasenko vda.linux at googlemail.com
Thu Dec 10 20:27:13 UTC 2009


commit: http://git.busybox.net/busybox/commit/?id=46a14771078744751ffa2bdb840c1bb4b005241c
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 shell/ash.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/shell/ash.c b/shell/ash.c
index 023294c..8d7c4ca 100644
--- a/shell/ash.c
+++ b/shell/ash.c
@@ -4213,15 +4213,16 @@ cmdputs(const char *s)
 	};
 
 	const char *p, *str;
-	char cc[2] = " ";
+	char cc[2];
 	char *nextc;
 	unsigned char c;
 	unsigned char subtype = 0;
 	int quoted = 0;
 
+	cc[1] = '\0';
 	nextc = makestrspace((strlen(s) + 1) * 8, cmdnextc);
 	p = s;
-	while ((c = *p++) != 0) {
+	while ((c = *p++) != '\0') {
 		str = NULL;
 		switch (c) {
 		case CTLESC:
@@ -4292,7 +4293,8 @@ cmdputs(const char *s)
 		while ((c = *str++) != '\0') {
 			USTPUTC(c, nextc);
 		}
-	}
+	} /* while *p++ not NUL */
+
 	if (quoted & 1) {
 		USTPUTC('"', nextc);
 	}
-- 
1.6.3.3



More information about the busybox-cvs mailing list