[Bug 747] 1.15.2 regression from 1.15.1 in ash parameter expansion

Sat Dec 5 15:12:27 UTC 2009

https://bugs.busybox.net/show_bug.cgi?id=747

--- Comment #19 from Davide Cavalca <davide at geexbox.org>  2009-12-05 15:12:27 UTC ---
(In reply to comment #18)
> (In reply to comment #14)
> > After unpacking the tarball, our unpack script does
> > cat <<EOF >$BUSYBOX/Makefile.custom
> > HOSTCC = $HOST_CC
> > CROSS_COMPILE = $TARGET_PREFIX
> > CFLAGS += -std=gnu99 
> > EOF
> 
> Wait a second. This basically nukes Makefile.custom! Why do you do it? You
> aren't satisfied with Makefile.custom as shipped?

Looks like this was an old workaround that somehow managed to stay in place.
Thanks for spotting it, I've removed it.

> I propose stopping doing that, and also passing any additional CFLAGS you need
> in EXTRA_CFLAGS, leaving CFLAGS not set.
> Anyway, the problem seems to be solved. And it is partially caused by you
> messing up build system. (On the bright side, ash.c code now is less buggy wrt
> architectures with signed chars).

I rewrote our busybox build script according to your suggestions and it works
fine now, feel free to close this bug.

Thanks for your help
Davide

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.