svn commit: trunk/busybox/util-linux/volume_id

vda at busybox.net vda at busybox.net
Sun Oct 19 19:54:49 UTC 2008


Author: vda
Date: 2008-10-19 12:54:49 -0700 (Sun, 19 Oct 2008)
New Revision: 23724

Log:
add comment explaining previous change



Modified:
   trunk/busybox/util-linux/volume_id/get_devname.c


Changeset:
Modified: trunk/busybox/util-linux/volume_id/get_devname.c
===================================================================
--- trunk/busybox/util-linux/volume_id/get_devname.c	2008-10-19 19:36:30 UTC (rev 23723)
+++ trunk/busybox/util-linux/volume_id/get_devname.c	2008-10-19 19:54:49 UTC (rev 23724)
@@ -107,6 +107,17 @@
 	if (uuidCache)
 		return;
 
+	/* We were scanning /proc/partitions
+	 * and /proc/sys/dev/cdrom/info here.
+	 * Missed volume managers. I see that "standard" blkid uses these:
+	 * /dev/mapper/control
+	 * /proc/devices
+	 * /proc/evms/volumes
+	 * /proc/lvm/VGs
+	 * This is unacceptably complex. Let's just scan /dev.
+	 * (Maybe add scanning of /sys/block/XXX/dev for devices
+	 * somehow not having their /dev/XXX entries created?) */
+
 	recursive_action("/dev", ACTION_RECURSE,
 		uuidcache_check_device, /* file_action */
 		NULL, /* dir_action */




More information about the busybox-cvs mailing list