svn commit: trunk/busybox/modutils

aldot at busybox.net aldot at busybox.net
Mon Jun 2 19:23:48 UTC 2008


Author: aldot
Date: 2008-06-02 12:23:47 -0700 (Mon, 02 Jun 2008)
New Revision: 22186

Log:
- add FIXME. Perhaps somebody is interrested in looking into this one.
  We would try to be clever and compare the *data instead of the *elt.

Somethink like this might be of more general use:
/* Unlink arbitrary element from the list that contains data */
void llist_unlink_data(llist_t **head, void *data)
{
    llist_t *elt;

    for (elt = *head; elt; elt = elt->link) {
        if (elt->data == data) {
            llist_unlink(elt);
            return;
        }
    }
}



Modified:
   trunk/busybox/modutils/depmod.c


Changeset:
Modified: trunk/busybox/modutils/depmod.c
===================================================================
--- trunk/busybox/modutils/depmod.c	2008-06-02 18:59:16 UTC (rev 22185)
+++ trunk/busybox/modutils/depmod.c	2008-06-02 19:23:47 UTC (rev 22186)
@@ -221,7 +221,7 @@
 				if (!strcmp(all->name, deps->data)) {
 					llist_t *implied = all->dependencies;
 					while (implied) {
-						/* erm, nicer would be to just
+						/* XXX:FIXME: erm, it would be nicer to just
 						 * llist_unlink(&mods->dependencies, implied)  */
 						llist_t *prune = mods->dependencies;
 						while (prune) {




More information about the busybox-cvs mailing list