[BusyBox 0002884]: ioctl() wrappers broken on 64-bit systems

bugs at busybox.net bugs at busybox.net
Thu Apr 10 23:08:54 UTC 2008


A NOTE has been added to this issue. 
====================================================================== 
http://busybox.net/bugs/view.php?id=2884 
====================================================================== 
Reported By:                ncase
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   2884
Category:                   Other
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
====================================================================== 
Date Submitted:             04-10-2008 16:06 PDT
Last Modified:              04-10-2008 16:08 PDT
====================================================================== 
Summary:                    ioctl() wrappers broken on 64-bit systems
Description: 
The ioctl_*() and bb_xioctl*() functions declare the second argument as
"int request" rather than "unsigned long int request" which break the
ioctl() calls on 64-bit systems.

This bug presented itself in the form of login failing during the termios
TCSETS call:

    getty: /dev/ttyS0: TCSETS: Invalid argument

I verified that changing the "request" argument to "unsigned long int"
fixes the problem.  It should leave 32-bit systems unaffected.  See
attached patch.
====================================================================== 

---------------------------------------------------------------------- 
 ncase - 04-10-08 16:08  
---------------------------------------------------------------------- 
The patches are for the unstable tree and also the busybox_1_9_stable tree. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
04-10-08 16:06  ncase          New Issue                                    
04-10-08 16:06  ncase          Status                   new => assigned     
04-10-08 16:06  ncase          Assigned To               => BusyBox         
04-10-08 16:06  ncase          File Added:
busybox-unstable-ioctl-64bit-fix.patch                    
04-10-08 16:08  ncase          File Added: busybox-stable-ioctl-64bit-fix.patch 
                  
04-10-08 16:08  ncase          Note Added: 0006514                          
======================================================================




More information about the busybox-cvs mailing list