svn commit: trunk/busybox: applets archival archival/libunarchive e etc...
vda at busybox.net
vda at busybox.net
Sun Mar 11 13:43:14 UTC 2007
Author: vda
Date: 2007-03-11 06:43:10 -0700 (Sun, 11 Mar 2007)
New Revision: 18066
Log:
kill superfluous returns at the end of void functions
Modified:
trunk/busybox/applets/applets.c
trunk/busybox/archival/dpkg.c
trunk/busybox/archival/libunarchive/data_align.c
trunk/busybox/archival/tar.c
trunk/busybox/e2fsprogs/old_e2fsprogs/blkid/devname.c
trunk/busybox/e2fsprogs/old_e2fsprogs/blkid/devno.c
trunk/busybox/e2fsprogs/old_e2fsprogs/blkid/read.c
trunk/busybox/e2fsprogs/old_e2fsprogs/e2fsck.c
trunk/busybox/e2fsprogs/old_e2fsprogs/ext2fs/bitmaps.c
trunk/busybox/e2fsprogs/old_e2fsprogs/ext2fs/inode.c
trunk/busybox/e2fsprogs/old_e2fsprogs/fsck.c
trunk/busybox/e2fsprogs/old_e2fsprogs/mke2fs.c
trunk/busybox/e2fsprogs/old_e2fsprogs/tune2fs.c
trunk/busybox/e2fsprogs/old_e2fsprogs/uuid/gen_uuid.c
trunk/busybox/editors/vi.c
trunk/busybox/miscutils/devfsd.c
trunk/busybox/networking/telnet.c
trunk/busybox/runit/runit_lib.c
Changeset:
Modified: trunk/busybox/applets/applets.c
===================================================================
--- trunk/busybox/applets/applets.c 2007-03-11 12:29:25 UTC (rev 18065)
+++ trunk/busybox/applets/applets.c 2007-03-11 13:43:10 UTC (rev 18066)
@@ -321,7 +321,6 @@
free(sct_head);
sct_head = sct;
}
- return;
}
#else
Modified: trunk/busybox/archival/dpkg.c
===================================================================
--- trunk/busybox/archival/dpkg.c 2007-03-11 12:29:25 UTC (rev 18065)
+++ trunk/busybox/archival/dpkg.c 2007-03-11 13:43:10 UTC (rev 18066)
@@ -706,7 +706,6 @@
new_status = xasprintf("%s %s %s", name_hashtable[want], name_hashtable[flag], name_hashtable[status]);
status_hashtable[status_node_num]->status = search_name_hashtable(new_status);
free(new_status);
- return;
}
static const char *describe_status(int status_num) {
@@ -763,7 +762,6 @@
free(control_buffer);
}
fclose(status_file);
- return;
}
static void write_buffer_no_status(FILE *new_status_file, const char *control_buffer)
@@ -780,7 +778,6 @@
fprintf(new_status_file, "%s: %s\n", name, value);
}
}
- return;
}
/* This could do with a cleanup */
@@ -1425,8 +1422,6 @@
/* Assign the tar handle as a subarchive of the ar handle */
ar_handle->sub_archive = tar_handle;
-
- return;
}
static void init_archive_deb_data(archive_handle_t *ar_handle)
@@ -1447,8 +1442,6 @@
/* Assign the tar handle as a subarchive of the ar handle */
ar_handle->sub_archive = tar_handle;
-
- return;
}
static char *deb_extract_control_file_to_buffer(archive_handle_t *ar_handle, llist_t *myaccept)
@@ -1472,7 +1465,6 @@
archive_handle->file_header->name = xasprintf("%s%s", archive_handle->buffer, name_ptr);
data_extract_all(archive_handle);
}
- return;
}
static void unpack_package(deb_file_t *deb_file)
Modified: trunk/busybox/archival/libunarchive/data_align.c
===================================================================
--- trunk/busybox/archival/libunarchive/data_align.c 2007-03-11 12:29:25 UTC (rev 18065)
+++ trunk/busybox/archival/libunarchive/data_align.c 2007-03-11 13:43:10 UTC (rev 18066)
@@ -5,9 +5,6 @@
#include <sys/types.h>
-#include <errno.h>
-#include <unistd.h>
-
#include "libbb.h"
#include "unarchive.h"
@@ -17,6 +14,4 @@
archive_handle->seek(archive_handle, skip_amount);
archive_handle->offset += skip_amount;
-
- return;
}
Modified: trunk/busybox/archival/tar.c
===================================================================
--- trunk/busybox/archival/tar.c 2007-03-11 12:29:25 UTC (rev 18065)
+++ trunk/busybox/archival/tar.c 2007-03-11 13:43:10 UTC (rev 18066)
@@ -134,7 +134,6 @@
}
*hlInfoHeadPtr = NULL;
}
- return;
}
/* Might be faster (and bigger) if the dev/ino were stored in numeric order;) */
Modified: trunk/busybox/e2fsprogs/old_e2fsprogs/blkid/devname.c
===================================================================
--- trunk/busybox/e2fsprogs/old_e2fsprogs/blkid/devname.c 2007-03-11 12:29:25 UTC (rev 18065)
+++ trunk/busybox/e2fsprogs/old_e2fsprogs/blkid/devname.c 2007-03-11 13:43:10 UTC (rev 18066)
@@ -131,7 +131,6 @@
pri = BLKID_PRI_MD;
if (dev)
dev->bid_pri = pri;
- return;
}
#define PROC_PARTITIONS "/proc/partitions"
Modified: trunk/busybox/e2fsprogs/old_e2fsprogs/blkid/devno.c
===================================================================
--- trunk/busybox/e2fsprogs/old_e2fsprogs/blkid/devno.c 2007-03-11 12:29:25 UTC (rev 18065)
+++ trunk/busybox/e2fsprogs/old_e2fsprogs/blkid/devno.c 2007-03-11 13:43:10 UTC (rev 18066)
@@ -122,7 +122,6 @@
}
}
closedir(dir);
- return;
}
/* Directories where we will try to search for device numbers */
Modified: trunk/busybox/e2fsprogs/old_e2fsprogs/blkid/read.c
===================================================================
--- trunk/busybox/e2fsprogs/old_e2fsprogs/blkid/read.c 2007-03-11 12:29:25 UTC (rev 18065)
+++ trunk/busybox/e2fsprogs/old_e2fsprogs/blkid/read.c 2007-03-11 13:43:10 UTC (rev 18066)
@@ -410,7 +410,6 @@
return;
errout:
close(fd);
- return;
}
#ifdef TEST_PROGRAM
Modified: trunk/busybox/e2fsprogs/old_e2fsprogs/e2fsck.c
===================================================================
--- trunk/busybox/e2fsprogs/old_e2fsprogs/e2fsck.c 2007-03-11 12:29:25 UTC (rev 18065)
+++ trunk/busybox/e2fsprogs/old_e2fsprogs/e2fsck.c 2007-03-11 13:43:10 UTC (rev 18066)
@@ -2286,7 +2286,6 @@
fix_problem(ctx, PR_0_ERR_MOVE_JOURNAL, &pctx);
fs->super->s_state &= ~EXT2_VALID_FS;
ext2fs_mark_super_dirty(fs);
- return;
}
/*
@@ -7328,8 +7327,6 @@
ext2fs_unmark_valid(fs);
}
dir->dotdot = parent;
-
- return;
}
/*
@@ -11969,7 +11966,6 @@
* Move the ext3 journal file, if necessary.
*/
e2fsck_move_ext3_journal(ctx);
- return;
}
/*
@@ -12666,7 +12662,6 @@
printf(_("check aborted.\n"));
exit (0);
}
- return;
}
static int is_on_batt(void)
Modified: trunk/busybox/e2fsprogs/old_e2fsprogs/ext2fs/bitmaps.c
===================================================================
--- trunk/busybox/e2fsprogs/old_e2fsprogs/ext2fs/bitmaps.c 2007-03-11 12:29:25 UTC (rev 18065)
+++ trunk/busybox/e2fsprogs/old_e2fsprogs/ext2fs/bitmaps.c 2007-03-11 13:43:10 UTC (rev 18066)
@@ -105,8 +105,6 @@
for (i=map->end+1, j = i - map->start; i <= map->real_end; i++, j++)
ext2fs_set_bit(j, map->bitmap);
-
- return;
}
errcode_t ext2fs_allocate_inode_bitmap(ext2_filsys fs,
Modified: trunk/busybox/e2fsprogs/old_e2fsprogs/ext2fs/inode.c
===================================================================
--- trunk/busybox/e2fsprogs/old_e2fsprogs/ext2fs/inode.c 2007-03-11 12:29:25 UTC (rev 18065)
+++ trunk/busybox/e2fsprogs/old_e2fsprogs/ext2fs/inode.c 2007-03-11 13:43:10 UTC (rev 18066)
@@ -178,7 +178,6 @@
ext2fs_free_mem(&scan->temp_buffer);
scan->temp_buffer = NULL;
ext2fs_free_mem(&scan);
- return;
}
void ext2fs_set_inode_callback(ext2_inode_scan scan,
Modified: trunk/busybox/e2fsprogs/old_e2fsprogs/fsck.c
===================================================================
--- trunk/busybox/e2fsprogs/old_e2fsprogs/fsck.c 2007-03-11 12:29:25 UTC (rev 18065)
+++ trunk/busybox/e2fsprogs/old_e2fsprogs/fsck.c 2007-03-11 13:43:10 UTC (rev 18066)
@@ -372,7 +372,6 @@
if (i->base_device)
free(i->base_device);
free(i);
- return;
}
static struct fs_info *create_fs_device(const char *device, const char *mntpnt,
Modified: trunk/busybox/e2fsprogs/old_e2fsprogs/mke2fs.c
===================================================================
--- trunk/busybox/e2fsprogs/old_e2fsprogs/mke2fs.c 2007-03-11 12:29:25 UTC (rev 18065)
+++ trunk/busybox/e2fsprogs/old_e2fsprogs/mke2fs.c 2007-03-11 13:43:10 UTC (rev 18066)
@@ -164,7 +164,6 @@
static void invalid_block(ext2_filsys fs EXT2FS_ATTR((unused)), blk_t blk)
{
bb_error_msg("Bad block %u out of range; ignored", blk);
- return;
}
/*
Modified: trunk/busybox/e2fsprogs/old_e2fsprogs/tune2fs.c
===================================================================
--- trunk/busybox/e2fsprogs/old_e2fsprogs/tune2fs.c 2007-03-11 12:29:25 UTC (rev 18065)
+++ trunk/busybox/e2fsprogs/old_e2fsprogs/tune2fs.c 2007-03-11 13:43:10 UTC (rev 18066)
@@ -340,7 +340,6 @@
fs->flags &= ~EXT2_FLAG_SUPER_ONLY;
}
print_check_message(fs);
- return;
}
/*
Modified: trunk/busybox/e2fsprogs/old_e2fsprogs/uuid/gen_uuid.c
===================================================================
--- trunk/busybox/e2fsprogs/old_e2fsprogs/uuid/gen_uuid.c 2007-03-11 12:29:25 UTC (rev 18065)
+++ trunk/busybox/e2fsprogs/old_e2fsprogs/uuid/gen_uuid.c 2007-03-11 13:43:10 UTC (rev 18066)
@@ -117,7 +117,6 @@
*/
for (cp = buf, i = 0; i < nbytes; i++)
*cp++ ^= (rand() >> 7) & 0xFF;
- return;
}
/*
Modified: trunk/busybox/editors/vi.c
===================================================================
--- trunk/busybox/editors/vi.c 2007-03-11 12:29:25 UTC (rev 18065)
+++ trunk/busybox/editors/vi.c 2007-03-11 13:43:10 UTC (rev 18066)
@@ -734,7 +734,7 @@
free(cfn); // free the old name
cfn = q; // remember new cfn
- vc5:
+ vc5:
// delete all the contents of text[]
new_text(2 * file_size(fn));
screenbegin = dot = end = text;
@@ -1919,7 +1919,6 @@
YDreg = 26; // go back to default Yank/Delete reg
#endif
adding2q = 0;
- return;
}
#endif /* FEATURE_VI_DOT_CMD */
@@ -1994,7 +1993,6 @@
//loiter= start_loiter= now;
}
}
- return;
}
static inline Byte *swap_context(Byte * p) // goto new context for '' command make this the current context
@@ -2591,8 +2589,6 @@
va_end(args);
have_status_msg = 1 + sizeof(SOs) + sizeof(SOn) - 2;
-
- return;
}
// format status buffer
@@ -2605,8 +2601,6 @@
va_end(args);
have_status_msg = 1;
-
- return;
}
static void ni(Byte * s) // display messages
@@ -3929,6 +3923,5 @@
totalcmds, M, N, I, D, Y, P, U, end - text + 1);
oldtim = tim;
}
- return;
}
#endif
Modified: trunk/busybox/miscutils/devfsd.c
===================================================================
--- trunk/busybox/miscutils/devfsd.c 2007-03-11 12:29:25 UTC (rev 18065)
+++ trunk/busybox/miscutils/devfsd.c 2007-03-11 13:43:10 UTC (rev 18066)
@@ -583,7 +583,6 @@
if(optional == 0 && errno == ENOENT)
msg_logger_and_die(LOG_ERR, "read config file: %s: %m", path);
}
- return;
} /* End Function read_config_file */
static void process_config_line (const char *line, unsigned long *event_mask)
@@ -969,7 +968,6 @@
ret = copy_inode (destination, &dest_stat, new_mode, source, &source_stat);
if (ENABLE_DEBUG && ret && (errno != EEXIST))
debug_msg_logger(LOG_ERR, "copy_inode: %s to %s: %m", source, destination);
- return;
} /* End Function action_copy */
static void action_compat (const struct devfsd_notify_struct *info, unsigned int action)
Modified: trunk/busybox/networking/telnet.c
===================================================================
--- trunk/busybox/networking/telnet.c 2007-03-11 12:29:25 UTC (rev 18065)
+++ trunk/busybox/networking/telnet.c 2007-03-11 13:43:10 UTC (rev 18066)
@@ -467,8 +467,6 @@
putiac2(DO, TELOPT_SGA);
else
putiac2(DONT, TELOPT_SGA);
-
- return;
}
#ifdef CONFIG_FEATURE_TELNET_TTYPE
@@ -480,8 +478,6 @@
putiac2(WILL, TELOPT_TTYPE);
else
putiac2(WONT, TELOPT_TTYPE);
-
- return;
}
#endif
@@ -494,8 +490,6 @@
putiac2(WILL, TELOPT_NEW_ENVIRON);
else
putiac2(WONT, TELOPT_NEW_ENVIRON);
-
- return;
}
#endif
@@ -504,29 +498,33 @@
{
/* Tell server we will do NAWS */
putiac2(WILL, TELOPT_NAWS);
- return;
}
#endif
static void telopt(byte c)
{
- switch (c)
- {
- case TELOPT_ECHO: to_echo(); break;
- case TELOPT_SGA: to_sga(); break;
+ switch (c) {
+ case TELOPT_ECHO:
+ to_echo(); break;
+ case TELOPT_SGA:
+ to_sga(); break;
#ifdef CONFIG_FEATURE_TELNET_TTYPE
- case TELOPT_TTYPE: to_ttype();break;
+ case TELOPT_TTYPE:
+ to_ttype(); break;
#endif
#ifdef CONFIG_FEATURE_TELNET_AUTOLOGIN
- case TELOPT_NEW_ENVIRON: to_new_environ(); break;
+ case TELOPT_NEW_ENVIRON:
+ to_new_environ(); break;
#endif
#ifdef CONFIG_FEATURE_AUTOWIDTH
- case TELOPT_NAWS: to_naws();
- putiac_naws(c, win_width, win_height);
- break;
+ case TELOPT_NAWS:
+ to_naws();
+ putiac_naws(c, win_width, win_height);
+ break;
#endif
- default: to_notsup(c);
- break;
+ default:
+ to_notsup(c);
+ break;
}
}
Modified: trunk/busybox/runit/runit_lib.c
===================================================================
--- trunk/busybox/runit/runit_lib.c 2007-03-11 12:29:25 UTC (rev 18065)
+++ trunk/busybox/runit/runit_lib.c 2007-03-11 13:43:10 UTC (rev 18066)
@@ -120,7 +120,6 @@
/* 4+1 + 2+1 + 2+1 + 2+1 + 2+1 + 2+1 + 9 = */
/* 5 + 3 + 3 + 3 + 3 + 3 + 9 = */
/* 20 (up to '.' inclusive) + 9 (not including '\0') */
- return;
}
unsigned fmt_taia25(char *s, struct taia *t) {
More information about the busybox-cvs
mailing list