[BusyBox 0001176]: Patches for undefined function of host_and_af2sockaddr without ENABLE_FEATURE_IPV6

bugs at busybox.net bugs at busybox.net
Fri Jan 26 07:01:49 UTC 2007


The following issue has been CLOSED 
====================================================================== 
http://busybox.net/bugs/view.php?id=1176 
====================================================================== 
Reported By:                rockeychu
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   1176
Category:                   Networking Support
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Resolution:                 open
Fixed in Version:           
====================================================================== 
Date Submitted:             01-25-2007 17:36 PST
Last Modified:              01-25-2007 23:01 PST
====================================================================== 
Summary:                    Patches for undefined function of
host_and_af2sockaddr without ENABLE_FEATURE_IPV6
Description: 
ping.c & arping need function host_and_af2sockaddr, even without
ENABLE_FEATURE_IPV6.

Patches as following:

Index: include/libbb.h
===================================================================
--- include/libbb.h     (revision 17534)
+++ include/libbb.h     (working copy)
@@ -316,10 +316,8 @@
  * (depending on host), but in theory nothing prevents e.g.
  * UNIX socket address being returned, IPX sockaddr etc... */
 len_and_sockaddr* host2sockaddr(const char *host, int port);
-#if ENABLE_FEATURE_IPV6
 /* Same, useful if you want to force family (e.g. IPv6) */
 len_and_sockaddr* host_and_af2sockaddr(const char *host, int port,
sa_family_t af);
-#endif
 /* Assign sin[6]_port member if the socket is of corresponding type,
  * otherwise no-op. Useful for ftp.
  * NB: does NOT do htons() internally, just direct assignment. */

Index: libbb/xconnect.c
===================================================================
--- libbb/xconnect.c    (revision 17534)
+++ libbb/xconnect.c    (working copy)
@@ -173,12 +173,10 @@
 #define str2sockaddr(host, port, af, ai_flags) str2sockaddr(host, port,
ai_flags)
 #endif

-#if ENABLE_FEATURE_IPV6
 len_and_sockaddr* host_and_af2sockaddr(const char *host, int port,
sa_family_t af)
 {
        return str2sockaddr(host, port, af, 0);
 }
-#endif

 len_and_sockaddr* host2sockaddr(const char *host, int port)
 {

====================================================================== 

---------------------------------------------------------------------- 
 vda - 01-25-07 23:01  
---------------------------------------------------------------------- 
fixed in rev 17535, thanks. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
01-25-07 17:36  rockeychu      New Issue                                    
01-25-07 17:36  rockeychu      Status                   new => assigned     
01-25-07 17:36  rockeychu      Assigned To               => BusyBox         
01-25-07 23:01  vda            Status                   assigned => closed  
01-25-07 23:01  vda            Note Added: 0002050                          
======================================================================




More information about the busybox-cvs mailing list