svn commit: trunk/busybox/networking

landley at landley at
Fri Sep 15 04:08:26 UTC 2006

Author: landley
Date: 2006-09-14 21:08:25 -0700 (Thu, 14 Sep 2006)
New Revision: 16126

So, in the cornucopia of superfulous warning directives I didn't add to the
tree, we have the warning about failed inlines (which with our inline
limit set to zero means any usage of the "inline" keyword at all).  Note
that setting the inline limit to zero, and using -Werror, both predated
adding the warning about inlines to the tree.  So whatever checkin added
that did nothing but break the tree.  But oh well.

The second category of superfluous warnings is warning about functions with
no previous declaration.  Apparently, if you add ALWAYS_INLINE to an empty
function definition, it considers the sucker undeclared as far as the
warning is concerned.  (I.E. it's a buggy warning.  I try not to ask the
compiler to generate warnings it can't competently generate.)

This is why I removed "inline" (unbreak allbareconfig), and couldn't replace it
with "ALWAYS_INLINE" (still broke allbareconfig).


Modified: trunk/busybox/networking/wget.c
--- trunk/busybox/networking/wget.c	2006-09-15 04:01:03 UTC (rev 16125)
+++ trunk/busybox/networking/wget.c	2006-09-15 04:08:25 UTC (rev 16126)
@@ -36,7 +36,7 @@
-static inline void progressmeter(int flag) {}
+static void progressmeter(int flag) {}
 static void close_and_delete_outfile(FILE* output, char *fname_out, int do_continue)

More information about the busybox-cvs mailing list