svn commit: trunk/busybox/include

landley at landley at
Fri Sep 15 04:01:04 UTC 2006

Author: landley
Date: 2006-09-14 21:01:03 -0700 (Thu, 14 Sep 2006)
New Revision: 16125

Unbreak allbareconfig.

We've had -Werror in the tree for quite a while, so adding #warning
somewhat counterproductve way to make comments on the code that belong on the
mailing list anyway.


Modified: trunk/busybox/include/libbb.h
--- trunk/busybox/include/libbb.h	2006-09-14 19:52:07 UTC (rev 16124)
+++ trunk/busybox/include/libbb.h	2006-09-15 04:01:03 UTC (rev 16125)
@@ -220,9 +220,6 @@
 extern int bb_printf(const char * __restrict format, ...)
 	__attribute__ ((format (printf, 1, 2)));
-#warning rename to xferror_filename?
 extern void xferror(FILE *fp, const char *fn);
 extern void xferror_stdout(void);
 extern void xfflush_stdout(void);
@@ -276,9 +273,6 @@
 extern long bb_xgetlarg10_sfx(const char *arg, const struct suffix_mult *suffixes);
-#warning pitchable now?
 extern unsigned long bb_xparse_number(const char *numstr,
 		const struct suffix_mult *suffixes);
@@ -340,9 +334,6 @@
 char *concat_subpath_file(const char *path, const char *filename);
 char *last_char_is(const char *s, int c);
-#warning yuk!
 char *fgets_str(FILE *file, const char *terminating_string);
 extern int uncompress(int fd_in, int fd_out);
@@ -356,9 +347,9 @@
 extern unsigned short bb_lookup_port(const char *port, const char *protocol, unsigned short default_port);
 extern void bb_lookup_host(struct sockaddr_in *s_in, const char *host);
-#warning wrap this?
+// This is declared here rather than #including <libgen.h> in order to avoid
+// confusing the two versions of basename.  See the dirname/basename man page
+// for details.
 char *dirname (char *path);
 int bb_make_directory (char *path, long mode, int flags);
@@ -471,9 +462,6 @@
-#warning put these in .o files
 /* The following devices are the same on devfs and non-devfs systems.  */
 #define CURRENT_TTY "/dev/tty"
 #define CONSOLE_DEV "/dev/console"

More information about the busybox-cvs mailing list