[BusyBox 0001060]: mmap(2) doesn't work on Blackfin in insmod (probably in other pacles too)

bugs at busybox.net bugs at busybox.net
Tue Nov 21 11:58:43 UTC 2006


The following issue has been CLOSED 
====================================================================== 
http://busybox.net/bugs/view.php?id=1060 
====================================================================== 
Reported By:                landau
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   1060
Category:                   Kernel Module Support
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Resolution:                 open
Fixed in Version:           
====================================================================== 
Date Submitted:             10-02-2006 23:14 PDT
Last Modified:              11-21-2006 03:58 PST
====================================================================== 
Summary:                    mmap(2) doesn't work  on Blackfin in insmod
(probably in other pacles too)
Description: 
Blackfin as a no-mmu architecture has spased support for mmap(2). One place
I encountered where it doesn't work is insmod (the one for 2.6.x kernels).
The attached patch uses read(2) if mmap(2) fails. This solves the problem
for Blackfin and shouldn't hurn anyone with an MMU.
====================================================================== 

---------------------------------------------------------------------- 
 vda - 11-21-06 03:56  
---------------------------------------------------------------------- 
We have this baby instead!! :)

xmalloc_open_read_close(filename, &len);

BTW, why we bother with mmap() _at _all? Are we afraid of little memcpy()
inherent in each read()? It's not like we are going to load gigabytes of
modules, eh? 

---------------------------------------------------------------------- 
 vda - 11-21-06 03:58  
---------------------------------------------------------------------- 
fixed in rev 16606. Consider testing it, though... 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
10-02-06 23:14  landau         New Issue                                    
10-02-06 23:14  landau         Status                   new => assigned     
10-02-06 23:14  landau         Assigned To               => BusyBox         
10-02-06 23:14  landau         File Added: insmod.patch                     
11-21-06 03:56  vda            Note Added: 0001751                          
11-21-06 03:58  vda            Status                   assigned => closed  
11-21-06 03:58  vda            Note Added: 0001752                          
======================================================================




More information about the busybox-cvs mailing list