[BusyBox 0001095]: cpio hardlink support and possible memory leak fix

bugs at busybox.net bugs at busybox.net
Tue Nov 21 00:53:24 UTC 2006


A NOTE has been added to this issue. 
====================================================================== 
http://busybox.net/bugs/view.php?id=1095 
====================================================================== 
Reported By:                eswierk
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   1095
Category:                   Other
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
====================================================================== 
Date Submitted:             11-20-2006 13:48 PST
Last Modified:              11-20-2006 16:53 PST
====================================================================== 
Summary:                    cpio hardlink support and possible memory leak fix
Description: 
A patch was posted to the busybox list about a month ago adding hardlink
support to cpio, and fixing a possible memory leak.  Hardlink support is
needed to handle initramfs archives.

The attached patch is slightly modified to apply cleanly against BusyBox
1.2.2.1.

====================================================================== 

---------------------------------------------------------------------- 
 vda - 11-20-06 16:43  
---------------------------------------------------------------------- 
What is this? statics? why this info in not incorporated into
archive_handle?

char get_header_cpio(archive_handle_t *archive_handle)
{
        static hardlinks_t *saved_hardlinks = NULL;
        static unsigned short pending_hardlinks = 0;
        static int inode; 

---------------------------------------------------------------------- 
 vda - 11-20-06 16:53  
---------------------------------------------------------------------- 
# make bloatcheck
function                                             old     new   delta
get_header_cpio                                      999    1059     +60
static.inode                                           -       4      +4
.rodata                                           193244  193212     -32
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 1/1 up/down: 64/-32)             Total: 32
bytes

Patch which is going to be applied to svn will be appached now, please
test and give feedback. But those statics are butt-ugly! 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
11-20-06 13:48  eswierk        New Issue                                    
11-20-06 13:48  eswierk        Status                   new => assigned     
11-20-06 13:48  eswierk        Assigned To               => BusyBox         
11-20-06 13:48  eswierk        File Added: busybox-200-cpio-hardlinks.patch     
              
11-20-06 13:49  eswierk        Issue Monitored: eswierk                     
11-20-06 16:43  vda            Note Added: 0001746                          
11-20-06 16:53  vda            Note Added: 0001747                          
======================================================================




More information about the busybox-cvs mailing list