svn commit: trunk/busybox/networking

Bernhard Fischer rep.nop at aon.at
Thu May 11 07:32:48 UTC 2006


On Wed, May 10, 2006 at 07:35:59PM -0700, vapier at busybox.net wrote:
>Author: vapier
>Date: 2006-05-10 19:35:55 -0700 (Wed, 10 May 2006)
>New Revision: 15061
>
>Log:
>fix no previous prototype warning
>
>Modified:
>   trunk/busybox/networking/interface.c
>
>
>Changeset:
>Modified: trunk/busybox/networking/interface.c
>===================================================================
>--- trunk/busybox/networking/interface.c	2006-05-11 02:31:45 UTC (rev 15060)
>+++ trunk/busybox/networking/interface.c	2006-05-11 02:35:55 UTC (rev 15061)
>@@ -1729,6 +1729,7 @@
> 	return res;
> }
> 
>+int display_interfaces(char *ifname);
> int display_interfaces(char *ifname)
> {
> 	int status;

I'm opposed to this change. This and the proto in route should be in
a header IFF they are exported.
Also the function itself has to live outside of a source-file which is
compiled conditionally, anything else is broken.
Please don't paper over this bug.



More information about the busybox-cvs mailing list