[BusyBox 0000903]: Missing #includes in some applets

bugs at busybox.net bugs at busybox.net
Wed Jun 14 09:22:08 UTC 2006


The following issue has been SUBMITTED. 
====================================================================== 
http://busybox.net/bugs/view.php?id=903 
====================================================================== 
Reported By:                iggarpe
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   903
Category:                   Standards Compliance
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
====================================================================== 
Date Submitted:             06-14-2006 02:22 PDT
Last Modified:              06-14-2006 02:22 PDT
====================================================================== 
Summary:                    Missing #includes in some applets
Description: 
insmod.c    should #include "libgen.h"
arping.c    should #include "net/if_arp.h"
ifconfig.c  should #include "sys/types.h"
nslookup.c  should #include "resolv.h"

And wherever "sys/fcntl.h" is used, "fcntl.h" should be used instead.

I say "should" because those files use functions and structures which are
defined in those headers. Currently, busybox WILL compile without errors
in any standard unix box because those headers are included somewhere in
the other included files.

However, if one tries to compile in other architechtures with different
libc, the erros will surface.

====================================================================== 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-14-06 02:22  iggarpe        New Issue                                    
06-14-06 02:22  iggarpe        Status                   new => assigned     
06-14-06 02:22  iggarpe        Assigned To               => BusyBox         
======================================================================




More information about the busybox-cvs mailing list