[BusyBox 0000634]: TFTP gets confused if it gets bad packet from server

[bugs at busybox.net]

The following issue has been SUBMITTED. 
====================================================================== 
http://busybox.net/bugs/view.php?id=634 
====================================================================== 
Reported By:                bakaitee
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   634
Category:                   Networking Support
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
====================================================================== 
Date Submitted:             01-10-2006 15:26 PST
Last Modified:              01-10-2006 15:26 PST
====================================================================== 
Summary:                    TFTP gets confused if it gets bad packet from server
Description: 
The tftp client has just 1 buffer, it uses same buffer for transmits and
receives.  If it receives a bad packet from the server, the comments says
"fall through for bad packets, discard the packet, treat as timeout". 
This is OK, but subsequently it should not use the information in the bad
packet (the packet is BAD). It does use this bad information, and ends up
sending garbage to the server. The servers tears down the tftp transfer.

The fix is simple, to maintain seperate send and receive buffers.  A patch
file that does this is attached. 
====================================================================== 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
01-10-06 15:26  bakaitee       New Issue                                    
01-10-06 15:26  bakaitee       Status                   new => assigned     
01-10-06 15:26  bakaitee       Assigned To               => BusyBox         
01-10-06 15:26  bakaitee       File Added: busybox-1.01_tftp0.patch             
      
======================================================================