[BusyBox 0000496]: Gunzip do not report correclty when uncompressing a corrupted gz file

[bugs at busybox.net]

The following issue has been CLOSED 
====================================================================== 
http://busybox.net/bugs/view.php?id=496 
====================================================================== 
Reported By:                xbc
Assigned To:                BusyBox
====================================================================== 
Project:                    BusyBox
Issue ID:                   496
Category:                   Other
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Resolution:                 open
Fixed in Version:           
====================================================================== 
Date Submitted:             10-21-2005 06:05 PDT
Last Modified:              01-09-2006 22:20 PST
====================================================================== 
Summary:                    Gunzip do not report correclty when uncompressing a
corrupted gz file
Description: 
We voluntary corrupted a gz file ( changing one byte ) then oncompressed it
with bb gunzip. In such a case, bb's gunzip
- spot the error correctly
- display a message about a CRC error
BUT
- return the same exit code as when the gz file is ok

We patched the thing, see attachment
====================================================================== 

---------------------------------------------------------------------- 
 robang74 - 12-27-05 02:57  
---------------------------------------------------------------------- 
This bug is still in bb version 1.01, but with different behaviure (see
below).
Anyway this bug and segmentation fault could be fixed using patch for 347
bug.
http://busybox.net/bugs/view.php?id=347


HOW TO REPRODUCE BUG:

busybox-1.01]$ cat busybox | gzip -9 > test.gz
busybox-1.01]$ cat test.gz | tr -d \  >test.gz0
busybox-1.01]$ ls -al test.gz*
-rw-r--r--  1 roberto users 136149 dic 27 11:51 test.gz
-rw-r--r--  1 roberto users 135682 dic 27 11:51 test.gz0


BEFORE PATCH 347:

busybox-1.01]$ ./busybox gunzip -t test.gz; echo $?
0
busybox-1.01]$ ./busybox gunzip -t test.gz0; echo $?
Segmentation fault
139


AFTER PATCH 347:

busybox-1.01_raf7]$ ./busybox gunzip -t test.gz; echo $?
0
busybox-1.01_raf7]$ ./busybox gunzip -t test.gz0; echo $?
gunzip: inflate error 2
1 

---------------------------------------------------------------------- 
 landley - 01-09-06 22:20  
---------------------------------------------------------------------- 
svn 13221 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
10-21-05 06:05  xbc            New Issue                                    
10-21-05 06:05  xbc            Status                   new => assigned     
10-21-05 06:05  xbc            Assigned To               => BusyBox         
10-21-05 06:05  xbc            File Added: decompress_unzip.patch               
    
12-27-05 02:57  robang74       Note Added: 0000819                          
12-27-05 02:57  robang74       Issue Monitored: robang74                    
01-09-06 22:20  landley        Status                   assigned => closed  
01-09-06 22:20  landley        Note Added: 0000905                          
======================================================================