[BusyBox-cvs] busybox/archival tar.c,1.191,1.192

Erik Andersen andersen at busybox.net
Wed May 5 10:37:51 UTC 2004


Update of /var/cvs/busybox/archival
In directory nail:/tmp/cvs-serv18443/archival

Modified Files:
	tar.c 
Log Message:
Steve Grubb writes:

Hello,

I found and patched 2 more bugs. The first is a misplaced semi-colon. The second
one is a buffer overflow. I doubt the buffer overflow is triggered in real life.
But you never know what those wily hackers are up to.

Thanks,
Steve Grubb



Index: tar.c
===================================================================
RCS file: /var/cvs/busybox/archival/tar.c,v
retrieving revision 1.191
retrieving revision 1.192
diff -u -d -r1.191 -r1.192
--- a/tar.c	25 Apr 2004 05:11:13 -0000	1.191
+++ b/tar.c	5 May 2004 10:37:48 -0000	1.192
@@ -477,8 +477,8 @@
 			dup2(gzipDataPipe[0], 0);
 			close(gzipDataPipe[1]);
 
-			if (tbInfo.tarFd != 1);
-			dup2(tbInfo.tarFd, 1);
+			if (tbInfo.tarFd != 1)
+				dup2(tbInfo.tarFd, 1);
 
 			close(gzipStatusPipe[0]);
 			fcntl(gzipStatusPipe[1], F_SETFD, FD_CLOEXEC);	/* close on exec shows sucess */




More information about the busybox-cvs mailing list