[Buildroot] [PATCH 1/1] package/dhcpcd: bump to latest git commit

Arnout Vandecappelle arnout at mind.be
Fri Mar 5 10:24:16 UTC 2021



On 05/03/2021 10:44, Fabrice Fontaine wrote:
> Hi Arnout,
> Le jeu. 4 mars 2021 à 21:26, Arnout Vandecappelle <arnout at mind.be> a écrit :
>>
>>
>>
>> On 03/03/2021 10:19, Fabrice Fontaine wrote:
>>> Bump to latest git commit to retrieve the following commits:
>>> - https://github.com/rsmarples/dhcpcd/commit/e3a40586dbb584774d0a17bc277e69cb500cfa38
>>> - https://github.com/rsmarples/dhcpcd/commit/f3f7332001d5d5722239f6b7279f32923e4eedd0
>>> - https://github.com/rsmarples/dhcpcd/commit/d670866ce008c21cbf6d5b20c4d4af6460ec35d2
>>> - https://github.com/rsmarples/dhcpcd/commit/19c3d9209a834e02918a17e011afd9da3e5be38d
>>> - https://github.com/rsmarples/dhcpcd/commit/82386110e67cf75c224e9817fce55e6b0f143266
>>> - https://github.com/rsmarples/dhcpcd/commit/dcfd7a23f002793a855156255e81662ef84064d3
>>> - https://github.com/rsmarples/dhcpcd/commit/166491c2953546a677073694036f43a65fc25063
>>
>>  This makes it seem as if the bump just comprises those commits. However, the
>> bump actually comprises about 40 other commits as well. This makes a much bigger
>> diff, and not something I think we are willing to take in just before the
>> 2021.02 release.
>>
>>  Therefore, I've instead cherry-picked the above commits and added them as
>> individual patches to Buildroot.
> Thanks, it makes sense however you didn't apply the updates on
> dhcpcd.mk. As a result, build will continue to fail with these archs
> on old kernels.

 Darn, looks like I reverted too much!

 I re-applied that part of the patch in a new commit, with you as the author
this time. Thanks for noticing!

 BTW, for complicated conditions like that which only depend on Kconfig symbols,
I prefer to do it in Config.in. Something like:

config BR2_PACKAGE_DHCPCD_ENABLE_PRIVSEP
	bool
	default y
	# Audit headers were only added in recent kernels for some arches
	depends on !BR2_or1k || BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7
	depends on !BR2_sh || BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7
	...

 But I didn't want to go and test all that, so I just applied your patch as-is.

 Regards,
 Arnout


>>
>>  I've also claimed authorship of the change (since nothing much was left of your
>> patch), but kept your SoB.
>>
>>  I hope there will be a new release of dhcpcd  soonish. Roy usually makes
>> several releases per month, but now it's almost 3 months ago...
>>
>>  Regards,
>>  Arnout
>>
>>>
>>> This will fix builds with arc, microblaze, nios2, or1k, sh, sparc and
>>> xtensa
>>>
>>> Update hash of LICENSE (update in year:
>>> https://github.com/rsmarples/dhcpcd/commit/f3d2ff551bb9b2919094ba6526dcebe217824f5c)
>>>
> Best Regards,
> 
> Fabrice
>>> Fixes:
>>>  - http://autobuild.buildroot.org/results/9ed863b3ba5e6e0587a48e619395e5bdb7e9c557
>>>  - http://autobuild.buildroot.org/results/affd2f094084c4f53a324830539d07050b83587e
>>>  - http://autobuild.buildroot.org/results/67f39606054930d307ddd0eb7743f06316d41544
>>>
>>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>


More information about the buildroot mailing list