[Buildroot] [PATCH] package/lvm2: default standard install to y
arnout at mind.be
Thu Jun 17 13:04:51 UTC 2021
On 17/06/2021 14:43, Peter Korsgaard wrote:
>>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be> writes:
> > Until commit 5c07dfcc1a52e2804011574a3e022523a20546c8
> > BR2_PACKAGE_LVM2_STANDARD_INSTALL would default to y. Indeed, the
> > default read:
> > default y if !BR2_PACKAGE_LVM2_DMSETUP_ONLY # legacy 2013.11
> > Since the legacy symbol is normally not selected, this defaults to y.
> > Commit 5c07dfcc1a52e2804011574a3e022523a20546c8 inadvertedly removed the
> > entire line instead of just the condition.
> > Fixes: https://bugs.busybox.net/show_bug.cgi?id=13846
> > For-stable: 2021.02, 2021.05
> > Cc: dominique.tronche at atos.net
> > Cc: Yann E. MORIN <yann.morin.1998 at free.fr>
> > Cc: Peter Korsgaard <peter at korsgaard.com>
> > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
> > --
> > As an experiment, I added the For-stable tag (which I invented myself).
> > Peter, is this useful? Should we propose this in the documentation?
> It could be. Typically just mentioning that this is a fix and/or CC me
> is enough, but it cannot hurt certainly.
I'm mostly thinking about finding out to which stable branches it applies.
Currently, contributors rarely go through the effort of checking that. So the
question is: is it worth your while to ask contributors to check to which stable
branches a fix is applicable?
I've added "Fixes: <sha1>" tags a few times, but then I realized it doesn't
actually help a lot.
More information about the buildroot