[Buildroot] [PATCHv3 06/15] package/sysrepo: remove explicit setting of CMAKE_BUILD_TYPE
Thomas De Schampheleire
patrickdepinguin at gmail.com
Tue Jun 1 14:24:32 UTC 2021
El mar, 25 may 2021 a las 22:56, Arnout Vandecappelle
(<arnout at mind.be>) escribió:
> On 25/05/2021 14:27, Thomas De Schampheleire wrote:
> > From: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
> > sysrepo explicitly sets CMAKE_BUILD_TYPE=Release, ignoring any possible
> > value of BR2_ENABLE_DEBUG (previously) or BR2_ENABLE_RUNTIME_DEBUG (now).
> > With the introduction of BR2_ENABLE_RUNTIME_DEBUG, this change should no
> > longer be necessary. Users that do not wish to have additional runtime
> > debugging just keep BR2_ENABLE_RUNTIME_DEBUG disabled (default value).
> > As the 'Debug' build type enables tests, disable them explicitly.
> > As the 'Debug' build type uses a custom REPO_PATH which does not exist on
> > target, force /etc/sysrepo like in the 'Release' build type.
> > Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
> Although I think this could have been squashed with the previous patch.
I thought a separate patch was intended based on your comment:
In v4 I'm sending the patch still separated but feel free to squash it.
More information about the buildroot