[Buildroot] [PATCH 1/1] package/linuxptp: remove hardcoded interface from config to args

Heiko Thiery heiko.thiery at gmail.com
Mon May 25 09:06:48 UTC 2020


Hi Michael, Hi Petr,

Am Do., 21. Mai 2020 um 23:22 Uhr schrieb Michael Walle <michael at walle.cc>:
>
> Hi all,
>
> Am 2020-05-21 15:36, schrieb Thomas Petazzoni:
> > Hello Heiko,
> >
> > On Wed, 20 May 2020 07:16:48 +0200
> > Heiko Thiery <heiko.thiery at gmail.com> wrote:
> >
> >> Interface configuration is hard coded in the config file. This will
> >> throw an error when this interace (eth0) is not present.
> >>
> >> This patch removes the interface to be used from the config and
> >> appends it
> >> to the PTP4L_ARGS. With this the custom arguments can be set via
> >> /etc/defaults/ptp4l.
> >
> > Well, you can also just as well provide your custom linuxptp.cfg in a
> > rootfs overlay, no?
>
> You can, but then you'd have to copy the configuration on each and every
> board which has another interface name than "eth0". That being said, I'd
> also prefer it to have the normal default config, shipped with linuxptp.
> Like at least debian does too.

A replacement of the currently used configuration could be a break in
backward compatibility? But as you said using the default linuxptp
configuraiton sounds to be a better solution. Since the currently used
config seems a use case from the initial committer (Petr Kulhavy).

-- 
Heiko



More information about the buildroot mailing list