[Buildroot] [PATCH 05/11] package/pkg-generic.mk: rework pkg_size logic with the "installed" step
thomas.petazzoni at bootlin.com
Sat May 2 09:52:46 UTC 2020
Thanks for taking the time to review this stuff!
On Fri, 1 May 2020 22:44:41 +0200
"Yann E. MORIN" <yann.morin.1998 at free.fr> wrote:
> I don't understand wy tht can't be achieved in the instrumentation hooks
> $(if $(filter start-configure,$(1)-$(2)),\
> $(call step_pkg_size_before,$(TARGET_DIR))\
> $(call step_pkg_size_before,$(STAGING_DIR),-staging)\
> $(call step_pkg_size_before,$(HOST_DIR),-host))
> $(if $(filter end-install,$(1)-$(2)),\
> $(call step_pkg_size_after,$(TARGET_DIR))\
> $(call step_pkg_size_after,$(STAGING_DIR),-staging)\
> $(call step_pkg_size_after,$(HOST_DIR),-host))
> Of course, it means you have to add a call the instrumentation hooks
> from the new 'install' step.
This wouldn't work for the configure step. See the code:
The hooks are called *before* we populate the per package directories.
But we need to capture the list of files *after* we populate the per
In addition, I don't really understand why we use those global
instrumentation hooks within the generic infra itself. It is just a lot
clearer to me to make those function calls directly than to have this
indirection through hooks.
For me, it's like using hooks for the configure, build or install steps
of a generic package. For example, do we typically do:
... do stuff ...
... do stuff ...
FOO_POST_BUILD_HOOKS += FOO_BUILD_THIS
We typically do the former, because there is no point in using hooks in
this situation. Hooks are useful to inject some logic to a step of
logic you don't have control over. When you have control over that step
of logic, hooks are kind of useless.
That being said, if you have a proposal to solve the ordering of things
in the configure step between the instrumentation hook and the
per-package directory population, I'm definitely fine with changing to
use instrumentation hooks.
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
More information about the buildroot