[Buildroot] [PATCH v2] binutils/ARC: cleanup
Vineet.Gupta1 at synopsys.com
Mon Jan 13 17:48:34 UTC 2020
On 12/22/19 1:41 PM, Thomas Petazzoni wrote:
> Hello Vineet,
> On Tue, 17 Dec 2019 13:32:53 -0800
> Vineet Gupta <Vineet.Gupta1 at synopsys.com> wrote:
>> Remove special handling for ARC - as it is not needed for cksy etc.
>> A nice side benefit is that the ARC specific version now only needs to
>> be specified in single place (vs 3 currently) in binutils/Config.in.host
>> Signed-off-by: Vineet Gupta <vgupta at synopsys.com>
>> package/binutils/binutils.mk | 6 +-----
>> 1 file changed, 1 insertion(+), 5 deletions(-)
>> diff --git a/package/binutils/binutils.mk b/package/binutils/binutils.mk
>> index a19d6940f7c1..3ae5561d67d3 100644
>> --- a/package/binutils/binutils.mk
>> +++ b/package/binutils/binutils.mk
>> @@ -8,14 +8,10 @@
>> # If not, we do like other packages
>> BINUTILS_VERSION = $(call qstrip,$(BR2_BINUTILS_VERSION))
>> ifeq ($(BINUTILS_VERSION),)
>> -ifeq ($(BR2_arc),y)
>> -BINUTILS_VERSION = arc-2019.09-rc1
>> BINUTILS_VERSION = 2.32
>> -endif # BINUTILS_VERSION
>> -ifeq ($(BINUTILS_VERSION),arc-2019.09-rc1)
>> +ifeq ($(BR2_BINUTILS_VERSION_ARC),y)
>> BINUTILS_SITE = $(call github,foss-for-synopsys-dwc-arc-processors,binutils-gdb,$(BINUTILS_VERSION))
>> BINUTILS_SOURCE = binutils-gdb-$(BINUTILS_VERSION).tar.gz
>> BINUTILS_FROM_GIT = y
> In fact, I was wrong, this also does not work, in the following
> - You're using a pre-compiled external toolchain, so host-binutils is
> not selected/enabled, so the version selection in
> package/binutils/Config.in.host is not used, and therefore
> BR2_BINUTILS_VERSION_ARC cannot be set to 'y'.
> - You have binutils enabled for the target.
> Then, with your patch, we will no longer select the ARC-specific fork
> of binutils.
> Basically, for the target binutils (just like for target gdb), we don't
> have any version selection, so we force using one specific version
> depending on the architecture.
Does that mean that other arch in that file (csky) with custom github location is
affected with the issue you mentioned above ?
More information about the buildroot