[Buildroot] [PATCH v3, 1/1] package/samba4: Do not force target python

Fabrice Fontaine fontaine.fabrice at gmail.com
Fri Jan 3 13:43:41 UTC 2020


Samba does not need python on the target for file server functionality.
It does need it for the Active Directory Domain Controller feature,
which is already configured in buildroot as optional and already depends
on python3 since commit 4485a75859fbae99090b065ddd7c088a65571d37.

An unnecessary target python greatly increases the size of the target
filesystem. A somewhat minimal configuration with a samba server shunk
from an 82 MB rootfs to 53 MB with this patch.

Signed-off-by: Trent Piepho <trent.piepho at synapse.com>
Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
---
Changes v2 -> v3 (after review of Thomas Petazzoni):
 - Only drop select in Config.in

Changes v1 -> v2 (after review of Thomas Petazzoni):
 - Rework patch due so it can be applied after commits
   fe033bdf534a7892ced72c11635d863afa92d1d2 and
   4485a75859fbae99090b065ddd7c088a65571d37

 package/samba4/Config.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/package/samba4/Config.in b/package/samba4/Config.in
index 493c79f3f8..a34eaa8088 100644
--- a/package/samba4/Config.in
+++ b/package/samba4/Config.in
@@ -18,7 +18,6 @@ config BR2_PACKAGE_SAMBA4
 	select BR2_PACKAGE_GNUTLS
 	select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
 	select BR2_PACKAGE_POPT
-	select BR2_PACKAGE_PYTHON3 if !BR2_PACKAGE_PYTHON
 	select BR2_PACKAGE_ZLIB
 	help
 	  Provides secure, stable and fast file and print services
-- 
2.24.0



More information about the buildroot mailing list