[Buildroot] [PATCH 1/1] package/sysklogd: bump to version 2.1.2

Thomas Petazzoni thomas.petazzoni at bootlin.com
Wed Dec 9 08:11:17 UTC 2020


Hello,

On Tue, 8 Dec 2020 21:41:27 +0100
Andreas Hilse <andreas.hilse at googlemail.com> wrote:

> Hello Thomas,
> 
> > I think the commit log should mention that the license has changed,
> > with a link to https://github.com/troglobit/sysklogd/releases/tag/v2.1.  
> Will do when I find out how to update the patch (have to read doc again).

git commit --amend

will allow you to update the commit log of the top-most commit.

Otherwise, I suggest you to document yourself about "git interactive
rebase", this is really the key functionality to understand to be able
to prepare patch series with Git.

> > syslog.c:448:27: error: ‘O_CLOEXEC’ undeclared (first use in this  
> function)
> >    O_WRONLY | O_NONBLOCK | O_CLOEXEC, 0)) >= 0) {  
> This is fixable by CFLAGS="-D_GNU_SOURCE" e.g. in MAKE_OPTS.
> I contacted the sysklogd maintainer through github. Waiting on a response.

Then the particular file using O_CLOEXEC should probably #define
_GNU_SOURCE before including any header file.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list