[Buildroot] [PATCH 1/2] package/re2: new package
buildroot at heine.tech
Sun Aug 30 14:34:03 UTC 2020
On 26.08.20 23:30, Thomas Petazzoni wrote:
> On Thu, 13 Aug 2020 16:45:48 +0200
> Michael Nosthoff via buildroot <buildroot at busybox.net> wrote:
>> RE2 is a fast, safe, thread-friendly alternative to backtracking
>> regular expression engines like those used in PCRE, Perl, and
>> Python. It is a C++ library.
>> Signed-off-by: Michael Nosthoff <buildroot at heine.tech>
>> package/Config.in | 1 +
>> package/re2/Config.in | 12 ++++++++++++
>> package/re2/re2.hash | 3 +++
>> package/re2/re2.mk | 25 +++++++++++++++++++++++++
>> 4 files changed, 41 insertions(+)
>> create mode 100644 package/re2/Config.in
>> create mode 100644 package/re2/re2.hash
>> create mode 100644 package/re2/re2.mk
> It seems like there is an issue with this package:
that's not good...
> Apparently, only a static version of libre2 gets installed, which is
> built without -fPIC (makes sense for a static library). But then it
> gets linked into a shared library, which booms as all the code in a
> shared library must be compiled with -fPIC.
> Perhaps the issue is that we're not explicitly passing
> -DBUILD_SHARED_LIBS=ON to host CMake packages in package/pkg-cmake.mk ?
> Could you have a look into this ?
What I'm wondering: Should all host packages always be built as shared libs?
From the CMake Documentation  (which is a bit unclear) I assume that
CMake will build libs as static. So it might be a coincidence that all
existing host cmake packages
built as shared as their default.
When comparing to package/pkg-autotools.mk I see that for host packages
is always set. So it would make sense to also add
to cmake host build flags.
I'm currently on vacation with no access to a proper machine for
building. So I would
be able to take care of this further earliest next week.
More information about the buildroot