[Buildroot] [PATCH 1/1] package/dieharder: fix build with gcc 10

Yann E. MORIN yann.morin.1998 at free.fr
Thu Aug 20 20:35:07 UTC 2020


Julien, All,

On 2020-08-20 08:21 +0200, Julien Viard de Galbert spake thusly:
[--SNIP--]
> As I introduced the package a few years ago, I was wondering if we had a
> way to measure the usage of this package and think about removing it.
> Then I checked with the guardians of the temple aka debian and found
> that the maintainer probably fixed the gcc 10 issue:
> 
> | dieharder (3.31.1.2-1) unstable; urgency=medium
> |
> |   * New upstream minor release accomodating gcc-10 and its treatment of
> |     multiple definitions of global variables		(Closes: #957134)
> |
> |   * Based on new 'upstream' git repo at github.com/eddelbuettel/dieharder
> |     which spawned off the salsa.debian.org repo for this package
> |
> |  -- Dirk Eddelbuettel <edd at debian.org>  Sat, 25 Jul 2020 12:36:49 -0500
> 
> This would not be the first time that debian extended the life of
> unmaintained upstream.
> 
> What do you think ?

I would be OK with switching to the github repo, indeed.

When you send the update patch, could you identify how much it has
diverged from the original upstream, too, so we can assess if that can
be considered for master (only bug fixes), or if it would go to next
(if there are features).

thanks for the heads up! :-)

Regards,
Yann E. MORIN.

> Regards,
> 
> Julien VdG
> 
> > 
> > Applied to master, thanks.
> > 
> > Regards,
> > Yann E. MORIN.
> > 
> > > ---
> > >  package/dieharder/dieharder.mk | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/package/dieharder/dieharder.mk b/package/dieharder/dieharder.mk
> > > index c3eee64553..cbf28922fd 100644
> > > --- a/package/dieharder/dieharder.mk
> > > +++ b/package/dieharder/dieharder.mk
> > > @@ -36,4 +36,9 @@ endif
> > >  # parallel build fail, disable it
> > >  DIEHARDER_MAKE = $(MAKE1)
> > >  
> > > +# Too many fixes needed to build with -fno-common which is default since gcc 10
> > > +ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_10),y)
> > > +DIEHARDER_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -fcommon"
> > > +endif
> > > +
> > >  $(eval $(autotools-package))
> > > -- 
> > > 2.27.0
> > > 
> > > _______________________________________________
> > > buildroot mailing list
> > > buildroot at busybox.net
> > > http://lists.busybox.net/mailman/listinfo/buildroot
> > 
> > -- 
> > .-----------------.--------------------.------------------.--------------------.
> > |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> > | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> > | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> > '------------------------------^-------^------------------^--------------------'

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



More information about the buildroot mailing list