[Buildroot] [PATCH v1 1/1] package/rtl8821au: add patch fixing sprintf error

Peter Seiderer ps.report at gmx.net
Sun Aug 2 10:51:41 UTC 2020


Hello Christian,

On Sat, 1 Aug 2020 14:43:32 -0700, Christian Stewart <christian at paral.in> wrote:

> Hi Peter,
>
>
>
> On Sat, Aug 1, 2020, 2:40 PM Peter Seiderer <ps.report at gmx.net> wrote:
>
> > Hello Christian,
> >
> > On Sat, 1 Aug 2020 23:34:10 +0200, Peter Seiderer <ps.report at gmx.net>
> > wrote:
> >
> > > Hello Christian,
> > >
> > >
> > > thanks for the patch, but...
> > >
> > > On Sat,  1 Aug 2020 13:37:49 -0700, Christian Stewart <
> > christian at paral.in> wrote:
> > >
> > > > Fixes compile errors against certain kernels.
> > > >
> > > > Signed-off-by: Christian Stewart <christian at paral.in>
> > > > ---
> > > >  ...f-for-extending-string-which-causes-.patch | 336 ++++++++++++++++++
> > > >  1 file changed, 336 insertions(+)
> > > >  create mode 100644
> > package/rtl8821au/0003-Fix-using-sprintf-for-extending-string-which-causes-.patch
> > > >
> > > > diff --git
> > a/package/rtl8821au/0003-Fix-using-sprintf-for-extending-string-which-causes-.patch
> > b/package/rtl8821au/0003-Fix-using-sprintf-for-extending-string-which-causes-.patch
> > > > new file mode 100644
> > > > index 0000000000..6753eefdd9
> > > > --- /dev/null
> > > > +++
> > b/package/rtl8821au/0003-Fix-using-sprintf-for-extending-string-which-causes-.patch
> > > > @@ -0,0 +1,336 @@
> > > > +From cc3262a32ce326d89d597bb8557ce0da05240e98 Mon Sep 17 00:00:00 2001
> > > > +From: Coleman <omegacoleman at gmail.com>
> > > > +Date: Fri, 17 Jul 2020 08:53:00 +0800
> > > > +Subject: [PATCH 3/3] Fix using sprintf for extending string, which
> > causes
> > > > + undefined behavior. (#334)
> > > > +
> > >
> > > The patch should have an note about the upstream source (see [1]), I
> > suspect you
> > > toke the patch from [2]?
> >
> > Or instead simple bump the package source version to the latest git commit
> > (as the patch is upstream committed)... ;-)
> >
>
> Can't do. The upstream has a commit that we don't follow. Apparently it has
> issues. Look at the PR on the repo.

Yes, your are right (and thanks for remind me of that point), maybe worth
a short remark at the commit log...

Regards,
Peter

>
> Thanks,
> christian




More information about the buildroot mailing list