[Buildroot] [PATCH v7 1/1] package/nodejs: use system-icu for host-nodejs

Peter Korsgaard peter at korsgaard.com
Thu Aug 13 16:44:23 UTC 2020


>>>>> "James" == James Hilliard <james.hilliard1 at gmail.com> writes:

 > The nodejs configure.py file orders zlib headers before the bundled ICU
 > headers. The zlib headers happen to be located in the system include
 > directory, next to some system ICU headers (not bundled). If these are
 > built before nodejs is, nodejs will get confused and try to use the
 > system ICU headers instead of the bundled ones.

 > Fix this by always using host-icu.

 > Set CXXFLAGS to -DU_DISABLE_RENAMING=1 when building with
 > system-icu since host-icu is built with --disable-renaming.

 > Fixes:
 >  - http://autobuild.buildroot.net/results/1ef947553ec762dba6a6202b1cfc84ceed75dbb2/

 > Signed-off-by: James Hilliard <james.hilliard1 at gmail.com>

Committed to 2020.02.x and 2020.05.x, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list