[Buildroot] [PATCH v3 1/2] package/python-colorlog: new package

Thomas Petazzoni thomas.petazzoni at bootlin.com
Thu Sep 19 21:25:28 UTC 2019


Hello,

On Mon, 16 Sep 2019 13:55:03 +0200
Joris Offouga <offougajoris at gmail.com> wrote:

> Colorlog is a formatter for the python logging module.
> 
> Signed-off-by: Joris Offouga <offougajoris at gmail.com>
> Reviewed-by: Yegor Yefremov <yegorslists at googlemail.com>

Thanks for your contribution, I've applied to master.

Two minor things that would have made this patch perfect:

 - The two patches for python-colorlog and python-simplelogging should
   have always been sent together. Even if only one of the two has
   changes, always send a new iteration of both patches. Otherwise,
   it's unclear that they are related, and depend on each other.

 - In the DEVELOPERS file, the entries end with a slash, i.e
   package/python-colorlog/ and not package/python-colorlog

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list