[Buildroot] [PATCH 1/1] package/collectd: add init script for SysV

Asaf Kahlon asafka7 at gmail.com
Sat Oct 26 07:20:11 UTC 2019


Hello,

On Sat, Oct 26, 2019 at 9:58 AM Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
>
> On Sat, 26 Oct 2019 08:50:13 +0300
> Asaf Kahlon <asafka7 at gmail.com> wrote:
>
> > Signed-off-by: Asaf Kahlon <asafka7 at gmail.com>
> > ---
> >  package/collectd/S90collectd | 33 +++++++++++++++++++++++++++++++++
> >  package/collectd/collectd.mk |  5 +++++
> >  2 files changed, 38 insertions(+)
> >  create mode 100644 package/collectd/S90collectd
> >
> > diff --git a/package/collectd/S90collectd b/package/collectd/S90collectd
> > new file mode 100644
> > index 0000000000..5caff17238
> > --- /dev/null
> > +++ b/package/collectd/S90collectd
> > @@ -0,0 +1,33 @@
> > +#!/bin/sh
> > +
> > +start() {
> > +     printf "Starting collectd... "
> > +     /usr/sbin/collectd
>
> I think we like to use start-stop-daemon in our init scripts. Any
> reason why you're not using start-stop-daemon here ?

Nothing special, I sent a v2.

>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

Regards,
Asaf.


More information about the buildroot mailing list