[Buildroot] [PATCH 09/18] checkpackagelib/lib_config.py: CommentsMenusPackagesOrder: drop function get_line

Jerzy Grzegorek jerzy.m.grzegorek at gmail.com
Fri Oct 4 06:52:35 UTC 2019


Hi Ricardo,

> Hello,
>
> On Tue, Sep 03, 2019 at 06:13 PM, Jerzy Grzegorek wrote:
>
>> Because function get_line() has only one line so use it inline.
> IMO it was better before this patch, so I would drop it, but if your patch
> convince a maintainer, I am OK too.
> So I will not give a tag, but it is not incorrect.

Ok, so I'll drop this patch.

Thanks for the review.

Regards,
Jerzy

> Regards, Ricardo




More information about the buildroot mailing list