[Buildroot] [PATCH 1/1] boot/arm-trusted-firmware: add missing host-uboot-tools select

Baruch Siach baruch at tkos.co.il
Tue Jul 23 13:24:37 UTC 2019


Hi Danomi,

On Tue, Jul 23, 2019 at 08:16:45AM -0400, Danomi Manchego wrote:
> On Tue, Jul 23, 2019 at 2:32 AM Baruch Siach <baruch at tkos.co.il> wrote:
> > On Mon, Jul 22, 2019 at 09:34:24PM -0400, Danomi Manchego wrote:
> > > The "Build BL31 U-Boot image" option uses mkimage to make atf-uboot.ub,
> > > and has a make dependency on host-uboot-tools.  Therefore, the Config.in
> > > option should select BR2_PACKAGE_HOST_UBOOT_TOOLS.  (Just like similar
> > > options in linux, package/xvisor, and fs/cpio.)
> > >
> > > Signed-off-by: Danomi Manchego <danomimanchego123 at gmail.com>
> > > ---
> > >  boot/arm-trusted-firmware/Config.in | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/boot/arm-trusted-firmware/Config.in b/boot/arm-trusted-firmware/Config.in
> > > index beb95fb..2e41bd0 100644
> > > --- a/boot/arm-trusted-firmware/Config.in
> > > +++ b/boot/arm-trusted-firmware/Config.in
> > > @@ -86,6 +86,7 @@ config BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31
> > >  config BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31_UBOOT
> > >       bool "Build BL31 U-Boot image"
> > >       select BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31
> > > +     select BR2_PACKAGE_HOST_UBOOT_TOOLS
> >
> > BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31_UBOOT adds host-uboot-tools to
> > ARM_TRUSTED_FIRMWARE_DEPENDENCIES already. Why isn't that enough?
> 
> Well, why isn't the dependency enough in xvisor for the
> BR2_PACKAGE_XVISOR_CREATE_UBOOT_IMAGE option?  Why isn't it enough in
> cpio for the BR2_TARGET_ROOTFS_CPIO_UIMAGE option?  I don't know, but
> I imagine that the answer is partially due to "truth in advertising"
> with regards to the menu configuration (because "host uboot-tools" can
> *appear* to be deselected but it gets built anyway if something
> depends on it but does not select it).
> 
> Isn't consistency with the other places reason enough?

It definitely is. But usually host dependencies are not selected at the 
Kconfig level. We have 33 matches to select.*PACKAGE_HOST_. Of these, 7 are 
BR2_PACKAGE_HOST_UBOOT_TOOLS. On the other hand, we have thousands of make 
level host dependencies that are not selected.

Not sure what the rule is.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -



More information about the buildroot mailing list