[Buildroot] [PATCH v2 2/2] boot/opensbi: Implement a choice for the OpenSBI Platform
alistair23 at gmail.com
Mon Jul 22 20:45:54 UTC 2019
On Sat, Jul 20, 2019 at 12:50 PM Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
> Hello Alistair,
> On Tue, 9 Jul 2019 15:36:49 -0700
> Alistair Francis <alistair.francis at wdc.com> wrote:
> > Instead of requiring users to look at the OpenSBI source code and
> > determine the platform string let's use a choice option to allow them to
> > specify the platform they would like to target. We still allow them to
> > specify a custom string if they want to.
> > Signed-off-by: Alistair Francis <alistair.francis at wdc.com>
> I have not applied this patch, because we don't do this anywhere in
> Buildroot. For things like U-Boot, Linux or Barebox, the name of the
> platform/configuration is always a free-form string. Having an explicit
> list of platform is difficult to maintain as the list of platforms can
> be huge. Also the list of supported platforms can differ from one
> version to the other (in the case where the version itself is
> configurable). In addition, how do you draw the line between platforms
> that should be explicitly listed in the Config.in choice, and the ones
> for which users should use the free-form string option.
> But again, the main reason for rejecting is that in exactly this
> situation in other packages in Buildroot, we use a simple free-form
No worries. As that was the main problem Mark had with the HiFive
Unleashed patches these should be good to merge.
I just sent a v2 with an updated readme to the list.
> Best regards,
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> buildroot mailing list
> buildroot at busybox.net
More information about the buildroot