[Buildroot] [RFC PATCH v2 1/2] makedevs: only warn on xattr when not enabled

Petr Vorel petr.vorel at gmail.com
Mon Jul 29 23:06:43 UTC 2019


Previously makedevs failed on adding xattr when
BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES was not enabled.
Now only warn. Therefore check for this configuration would be required
in each use. But no package is using it so far (it's used only in tests).

Signed-off-by: Petr Vorel <petr.vorel at gmail.com>
---
Hi,

this supersede this patch:
https://patchwork.ozlabs.org/patch/1138055/

Unfortunately I wasn't able to test it as
buildroot/output/build/buildroot-fs/tar/fakeroot is not working for me.
Can anyone test it?

Kind regards,
Petr

 package/makedevs/makedevs.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/makedevs/makedevs.c b/package/makedevs/makedevs.c
index c57b964f5c..ab35b8e70d 100644
--- a/package/makedevs/makedevs.c
+++ b/package/makedevs/makedevs.c
@@ -518,8 +518,9 @@ int main(int argc, char **argv)
 			if (bb_set_xattr(full_name, xattr) < 0)
 				bb_error_msg_and_die("can't set cap %s on file %s\n", xattr, full_name);
 #else
-			bb_error_msg_and_die("line %d not supported: '%s'\nDid you forget to enable "
-					     "BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES?\n",
+			bb_error_msg("line %d not supported: '%s'\nEnable "
+					     "BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES"
+						 "to get xattr support\n",
 					     linenum, line);
 #endif /* EXTENDED_ATTRIBUTES */
 			continue;
-- 
2.22.0



More information about the buildroot mailing list