[Buildroot] [PATCH v2 2/2] checkpackagelib/lib_config.py: check packages alphabetical order in {Config.in, Config.in.host}

Arnout Vandecappelle arnout at mind.be
Sat Jul 13 22:27:25 UTC 2019

 Hi Jerzy,

On 11/06/2019 22:49, Jerzy Grzegorek wrote:
> Signed-off-by: Jerzy Grzegorek <jerzy.m.grzegorek at gmail.com>

 Applied both to master, thanks.

 I still made a lot of changes, though:

     - calculate level by counting - instead of with a static array;
     - new_package is only used locally, so don't make it a class member;
     - do indentation according to length of prefix;
     - don't split string in the middle of a line;
     - report first wrong package per menu;
     - do replace() only once;
     - add comment why we do replace().

 Please take a look at the end result, and if there's something you don't like,
send a follow-up patch.


> ---
> Changes v1 -> v2:
>  - swap patches 1 and 2 (Arnout)
>  - drop trailing lines (copy/paste side effect)
>  - rewrap lines to < 80 chars
>  - add variable to cut lines to < 80 chars
>  - change alphabetical order of '_" to go before digits (Arnout)
> TODO : checking of menu of comments and menu of menus

More information about the buildroot mailing list