[Buildroot] [PATCH v3 3/3] package/mpd: bump to version 0.21.7
arnout at mind.be
Thu Jul 4 17:34:52 UTC 2019
On 04/07/2019 19:31, Jörg Krause wrote:
> Hi Arnout,
> On Thu, 2019-07-04 at 19:21 +0200, Arnout Vandecappelle wrote:
>> On 04/07/2019 12:43, Jörg Krause wrote:
>>> MPD changed from Autotools to the Meson build system.
>>> Add config options for the qobuz and tidal plugins and group them together
>>> with the soundcloud plugin under "Commercial services".
>>> Signed-off-by: Jörg Krause <joerg.krause at embedded.rocks>
>> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
>> Is there any reason why you didn't do the bump to 0.21.11 already?
> The only reason is that the patch was first proposed when version
> 0.21.7 was the most recent version back then. Shall I bump to version
> 0.21.11 instead (and change the commit message)?
I'd think that that is easier than making an additional patch for the
>>> ifeq ($(BR2_PACKAGE_MPD_TREMOR),y)
>>> MPD_DEPENDENCIES += tremor
>>> -# Help mpd to find tremor in static linking scenarios
>>> -MPD_CONF_ENV += \
>>> - TREMOR_LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs vorbisidec`"
>>> -MPD_CONF_OPTS += --with-tremor=$(STAGING_DIR)/usr
>> I guess this is no longer needed because meson properly uses pkg-config. Have
>> you tested that?
> You're right, this is no longer needed and can safely be removed.
If you're anyway respinning, please mention it in the commit message.
More information about the buildroot