[Buildroot] [PATCH] qemu: Change CPU in qemu command for aarch64

Peter Korsgaard peter at korsgaard.com
Tue Jan 29 22:03:52 UTC 2019

>>>>> "Peter" == Peter Korsgaard <peter at korsgaard.com> writes:

>>>>> "Gerome" == Gerome Burlats <gerome.burlats at smile.fr> writes:
 >> This commit changes to "cortex-a53" the CPU model in the qemu command
 >> for aarch64 (since it is the default one for this architecture).

 >> Signed-off-by: Gerome Burlats <gerome.burlats at smile.fr>
 >> Cc: Romain Naour <romain.naour at smile.fr>
 >> ---

 >> cortex-a53 is the default cpu for aarch64, but some defconfigs, for
 >> example raspberrypi3_64_defconfig, still have "BR2_cortex_a53=y"
 >> (maybe at one point, this cpu was not the default).
 >> Should this line stay in the defconfig for info, even if it is not used ?
 >> If we generate the defconfig with "make savedefconfig", BR2_cortex_a53=y is indeed not added in the file.

 > Correct. We typically do add for clarity and robustness against changes
 > of the default value.

 > It is correct that savedefconfig will strip such redundant entries, but
 > as you can see from the comments, qemu_aarch64_virt_defconfig is edited
 > by hand.

 > Committed after extending the commit message and adding an explicit
 > BR2_cortex_a53=y to the defconfig, thanks.

Committed to 2018.02.x and 2018.11.x, thanks.

Bye, Peter Korsgaard

More information about the buildroot mailing list