[Buildroot] [PATCH] package/gst1-plugins-bad: fix build with fdk-aac 2.0
ryan.barnett at rockwellcollins.com
Wed Jan 16 23:08:43 UTC 2019
On Wed, Jan 16, 2019 at 4:22 PM Peter Korsgaard <peter at korsgaard.com> wrote:
> >>>>> "Ryan" == Ryan Barnett <ryan.barnett at rockwellcollins.com> writes:
> > Peter,
> > On Wed, Jan 16, 2019 at 3:49 PM Peter Korsgaard <peter at korsgaard.com> wrote:
> >> Fixes:
> >> http://autobuild.buildroot.net/results/343/343249ab34ab77be3b8077f544b9d1e2d4852796/
> >> http://autobuild.buildroot.net/results/edc/edca961f2c4d1946385ac86a756308caaf22d79d/
> >> Fdk-aac 2.0 dropped some legacy APIs, breaking the build of the fdk-aac
> >> plugin. Add two upstream upstream patches to fix building against fdk-aac
> >> 2.0.
> >> Signed-off-by: Peter Korsgaard <peter at korsgaard.com>
> >> +++ b/package/gstreamer1/gst1-plugins-bad/0002-fdkaacdec-Use-WAV-channel-mapping-instead-of-interle.patch
> >> @@ -0,0 +1,47 @@
> >> +From 19d34f6b5e1633d5ec4bb2832c58470f0c829cab Mon Sep 17 00:00:00 2001
> >> +From: "Jan Alexander Steffens (heftig)" <jan.steffens at gmail.com>
> >> +Date: Wed, 5 Dec 2018 10:10:39 +0100
> >> +Subject: [PATCH] fdkaacdec: Use WAV channel mapping instead of interleave
> >> + setting
> >> +
> >> +The latter is going away in libfdk-aac 2.0.0. Instead, MPEG-style output
> >> +is always non-interleaved and WAV-style output is always interleaved.
> >> +Earlier libfdk-aac also defaults interleaving accordingly.
> >> +
> >> +Since our reordering looks at the associated PCE indices instead of the
> >> +actual channel order, we're agnostic to the mapping.
> >> +
> >> +For https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/825
> > Minor nit - missing your "Signed-off-by" line here.
> Ups, indeed - I'll fix that when applying, thanks.
> I also didn't see your Reviewed-by in your reply :P
Here you go :)
Reviewed-by: Ryan Barnett <ryan.barnett at rockwellcollins.com>
> Bye, Peter Korsgaard
More information about the buildroot