[Buildroot] [PATCH] package/apitrace: fix build failure due to gcc bug 68485 and 85180

Giulio Benetti giulio.benetti at benettiengineering.com
Tue Dec 31 15:04:31 UTC 2019


Hi Thomas,

On 12/31/19 3:33 PM, Thomas Petazzoni wrote:
> On Fri, 27 Dec 2019 19:00:20 +0100
> Giulio Benetti <giulio.benetti at benettiengineering.com> wrote:
> 
>> +APITRACE_CFLAGS = $(TARGET_CFLAGS)
>> +
>> +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y)
>> +APITRACE_CFLAGS += -O0
>> +endif
>> +
>> +APITRACE_CONF_OPTS += -DCMAKE_C_FLAGS="$(APITRACE_CFLAGS)"
>> +
>> +APITRACE_CXXFLAGS = $(TARGET_CXXFLAGS)
>> +
>> +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
>> +APITRACE_CXXFLAGS += -O0
>> +endif
>> +
>> +APITRACE_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(APITRACE_CXXFLAGS)"
> 
> I'm a bit confused as to why the bug 68485 is worked-around through
> CFLAGS and bug 85180 is worked-around through CXXFLAGS. Could you
> explain this ?

Sure, gcc bug 68485 is due to (included 3rd party) brotli, and it 
manifests compiling C files, while gcc bug 85180 manifests on apitrace 
while compiling C++ files.

Best regards
-- 
Giulio Benetti
Benetti Engineering sas
> 
> Thanks,
> 
> Thomas
> 


More information about the buildroot mailing list