[Buildroot] [PATCH 1/4] package/xenomai: Smokey's not a skin

Thomas Petazzoni thomas.petazzoni at bootlin.com
Thu Dec 12 20:48:20 UTC 2019


On Thu, 12 Dec 2019 19:44:37 +0100
Jan Kiszka <jan.kiszka at siemens.com> wrote:

> From: Jan Kiszka <jan.kiszka at siemens.com>
> 
> That's a testsuite tool.
> 
> Rename XENOMAI_REMOVE_SKIN_LIST at this chance as it's cleaning
> libraries.

I am confused, aren't psos, rtai, uitron, vxworks and al. called
"skins" in the Xenomai speak ?

Ideally, this variable rename should be done in a separate patch, since
it's independent from the smokey option removal.

> Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
> ---
>  package/xenomai/Config.in  |  5 -----
>  package/xenomai/xenomai.mk | 23 ++++++++++-------------
>  2 files changed, 10 insertions(+), 18 deletions(-)
> 
> diff --git a/package/xenomai/Config.in b/package/xenomai/Config.in
> index 83ba8ca162..0cb0b343de 100644
> --- a/package/xenomai/Config.in
> +++ b/package/xenomai/Config.in
> @@ -170,11 +170,6 @@ config BR2_PACKAGE_XENOMAI_RTAI_SKIN
>  	help
>  	  This option allows to install the RTAI Xenomai skin
>  
> -config BR2_PACKAGE_XENOMAI_SMOKEY_SKIN
> -	bool "Smokey skin"
> -	help
> -	  This option allows to install the Smokey Xenomai skin

We normally want to have Config.in.legacy handling when removing
options, but in this case, the options was in fact not really doing
anything useful, so I believe it's OK to just drop it like you did.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list