[Buildroot] [PATCH 1/1] package/avro: new package

Titouan Christophe titouan.christophe at railnova.eu
Wed Dec 11 10:29:59 UTC 2019


Hello Gilles and all,

On 12/10/19 8:46 PM, Gilles Talis wrote:
> Hello Christophe,
> 
> Thanks for your contribution
> 
> I would be very interested to have other people's opinion on this one,
> but I think it'd be neater to follow the protobuf "architecture":
> - one package for protobuf
> - one package for python-protobuf
> 
> Similarly, you could create:
> - one package for avro-c
> - one package for python-avro
> (another package for avro-cpp eventually

Because I used the single archive (see your next remark below), I draw 
inspiration from the alsa-lib package, which provides both the C lib and 
a python package.

> 
> Moreover, these packages seem to have been nicely separated upstream:
> - avro-c: https://www-eu.apache.org/dist/avro/avro-1.9.1/c/avro-c-1.9.1.tar.gz
> - avro-python3:
> https://www-eu.apache.org/dist/avro/avro-1.9.1/py3/avro-python3-1.9.1.tar.gz
> 

Shame on me, I did not even notice that these nicely separated archives 
were distributed upstream. I'll change that and send a new version.

Using these separated archives would therefore make much more sense in 
their respective "sections" (python-avro, etc...)

> I have not run an exact diff between the avro-src-xxx.tar.gz and the
> other source packages, but if they match, I would recommend using the
> "protobuf" method.
> 
> Thanks
> Gilles.
> 

Thanks for your review !

Titouan


More information about the buildroot mailing list