[Buildroot] [PATCH 1/1] package/git: Fix build with NLS enabled
peter at korsgaard.com
Fri Apr 26 12:30:00 UTC 2019
>>>>> "Vadim" == Vadim Kochan <vadim4j at gmail.com> writes:
> git fails to build with NLS enabled because of weak check
> for gettext in configure.ac. The AC_CHECK_LIB(c, gettext ...)
> is used to set LIBC_CONTAINS_LIBINTL variable. If the variable
> is set then '-libs' is not passed to the linker, but this variable
> is set to 'Yes' even libc implementation does not provide libintl
> support, the AC_CHECK passes because gcc has gettext builtin.
> So use instead AC_LINK_IFELSE with included libintl.h because it
> makes gettext to unfold as libintl_gettext which causes AC_CHECK
> to fail for cases when gettext is not provided by libc.
> Tested by ./utils/test-pkg with NLS disabled/enabled.
> Signed-off-by: Vadim Kochan <vadim4j at gmail.com>
Committed to 2019.02.x, thanks.
Bye, Peter Korsgaard
More information about the buildroot