[Buildroot] [PATCH 1/1] package/dhcp: always disable zlib in bind library

Thomas Petazzoni thomas.petazzoni at bootlin.com
Tue Apr 23 07:28:25 UTC 2019


Hello Fabrice,

On Mon, 22 Apr 2019 23:19:04 +0200
Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:

> > Thanks to this, zlib is properly built before dhcp, and everything
> > works fine.  
> This is strange because I think I also tried this fix and the build
> failure was not fixed because if no value is provided to zlib, the
> configure script will try to find zlib header on host (see
> dhcp/bind/bind-9.11.2-P1/configure.in):
> 
>     auto|yes)
>         for d in /usr /usr/local /opt/local
>         do
>             if test -f "${d}/include/zlib.h"
>             then
>                 if test ${d} != /usr
>                 then
>                     zlib_cflags="-I ${d}/include"
>                     LIBS="$LIBS -L${d}/lib"
>                 fi
>                 have_zlib="yes"
>             fi
>         done
>         ;;
> 
> And obviously, build will fail if those headers are found on host.
> So I think, we should also set --with-zlib=$(STAGING_DIR)/usr but it
> was also failing.

Hum, OK, I see. I do have the Zlib development files installed on my
system though, and /usr/include/zlib.h exists.

> I'll investigate a little more to find why if you think that disabling
> zlib is not a good solution.

OK. Actually, it was not really well explained in your commit log /
comment what the problem was. It felt like "it doesn't work, so let's
take the easy route". If indeed the zlib detection is too broken, I'm
perfectly fine with disabling it. But the reason is not "let's disable
it like other dependencies".

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list