[Buildroot] [PATCH 1/1] package/dhcp: always disable zlib in bind library

Thomas Petazzoni thomas.petazzoni at bootlin.com
Mon Apr 22 20:39:52 UTC 2019


Hello Fabrice,

On Sun, 21 Apr 2019 19:10:39 +0200
Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:

> +# Always disable zlib in bind library (like all other dependencies, see
> +# bind/Makefile.in)

This reason looked suspicious to me, so I investigated, and indeed, I
think it's not the right fix.

> +DHCP_BIND_CONF_OPTS = --without-zlib
> +
>  ifeq ($(BR2_PACKAGE_DHCP_SERVER_DELAYED_ACK),y)
>  DHCP_CONF_OPTS += --enable-delayed-ack
>  endif
>  
> -ifeq ($(BR2_PACKAGE_ZLIB),y)

The right fix is:

DHCP_DEPENDENCIES += zlib

> -DHCP_BIND_CONF_OPTS += --with-zlib
> -else
> -DHCP_BIND_CONF_OPTS += --without-zlib
> -endif

Thanks to this, zlib is properly built before dhcp, and everything
works fine.

I committed a fix that does this.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list