[Buildroot] [PATCH v3 1/1] package/gettext: Fix GETTEXTIZE is not defined in case of full gettext

Thomas Petazzoni thomas.petazzoni at bootlin.com
Wed Apr 10 11:36:58 UTC 2019

Hello Vadim,

On Mon,  8 Apr 2019 23:31:32 +0300
Vadim Kochan <vadim4j at gmail.com> wrote:

> After introducing gettext-tiny in:
> 	5367a1b253 package/gettext-tiny: new package
> GETTEXTIZE variable is conditionally defined separately by gettext-gnu
> or gettext-tiny package depending on which of them is enabled. But it
> causes the issue when BR2_TOOLCHAIN_HAS_FULL_GETTEXT=y, because in that
> case BR2_PACKAGE_GETTEXT is not selected by BR2_SYSTEM_ENABLE_NLS config
> and GETTEXTIZE is not defined, which causes build fail for packages
> which uses gettextizing (e.g. host-flex).
> Fix issue by defining GETTEXTIZE unconditionally in
> package/gettext/gettext.mk. It is not needed to define it in each
> gettext-*.mk because the difference is only in passing 'data_dir'
> parameter which points to ${PREFIX}/share/gettext-tiny (in case of
> gettext-tiny provider), but simple linking:
> 	${PREFIX}/share/gettext -> ${PREFIX}/share/gettext-tiny
> solves this issue.
> Reported-by: Romain Naour <romain.naour at gmail.com>
> Signed-off-by: Vadim Kochan <vadim4j at gmail.com>
> ---
> v3:
>     Make commit message more descriptive and cleaner, also fix 'data_dir'
>     explanation which was not updated in v2.

Applied to master after reworking the commit log. Thanks!

Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering

More information about the buildroot mailing list