[Buildroot] [PATCH] support/dependencies/dependencies.sh: simplify an error message

Peter Korsgaard peter at korsgaard.com
Wed Apr 10 05:46:40 UTC 2019


>>>>> "Markus" == Markus Mayer <mmayer at broadcom.com> writes:

 > There is no need to break the "\n" sequence using "%sn". We can just
 > escape it. Note: the escaping backslash needs to be escaped too,
 > because the shell will process the string before printf gets to see it.

 > Signed-off-by: Markus Mayer <mmayer at broadcom.com>

Maybe we should have used single quotes here to get rid of one layer of
quoting.

Committed, thanks.

> ---
 >  support/dependencies/dependencies.sh | 3 +--
 >  1 file changed, 1 insertion(+), 2 deletions(-)

 > diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh
 > index 826874baa2e8..1d5c164aa65b 100755
 > --- a/support/dependencies/dependencies.sh
 > +++ b/support/dependencies/dependencies.sh
 > @@ -37,8 +37,7 @@ case ":${PATH:-unset}:" in
 >  	;;
 >  (*"
 >  "*)	printf "\n"
 > -	# Break the '\n' sequence, or a \n is printed (which is not what we want).
 > -	printf "Your PATH contains a newline (%sn) character.\n" "\\"
 > +	printf "Your PATH contains a newline (\\\n) character.\n"
 >  	printf "This doesn't work. Fix you PATH.\n"
 >  	exit 1
 >  	;;
 > -- 
 > 2.17.1

 > _______________________________________________
 > buildroot mailing list
 > buildroot at busybox.net
 > http://lists.busybox.net/mailman/listinfo/buildroot

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list