[Buildroot] [PATCH 1/3] package/s6-linux-init: Build also for the host
vadim4j at gmail.com
Tue Apr 2 15:48:23 UTC 2019
On Wed, Mar 27, 2019 at 05:55:03PM +0100, Thomas Petazzoni wrote:
> Hello Vadim,
> I am not familiar with s6, so sorry if I'm asking silly questions in
> this review.
> On Sat, 16 Feb 2019 23:28:33 +0200
> Vadim Kochan <vadim4j at gmail.com> wrote:
> > Add strict dependency for host-s6-linux-init to use s6-linux-init-maker
> > on the host during the rootfs generation.
> I think the wording is not great here: "strict dependency" does not
> mean anything in the typical Buildroot speak. I think you wanted to say
> "We add host-s6-linux-init as a dependency of the target s6-linux-init,
> so that the latter can use the s6-linux-init-maker program as part of
> its build process".
> However, I think adding this dependency should belong to PATCH 2/3,
> where s6-linux-init is actually changed to use s6-linux-init-maker.
> Indeed, as I understand it, it's only starting with PATCH 2/3 that
> s6-linux-init will need this program. Is this correct ?
Yes, will move it to the PATCH 2/3.
> If it is, then PATCH 1/3 should only change s6-linux-init.mk to add the
> host variant of s6-linux-init.
More information about the buildroot